Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_sql_server: Enable SystemAssigned identity #4754

Merged
merged 4 commits into from Oct 30, 2019
Merged

azurerm_sql_server: Enable SystemAssigned identity #4754

merged 4 commits into from Oct 30, 2019

Conversation

bgs113
Copy link
Contributor

@bgs113 bgs113 commented Oct 29, 2019

This provides the capability to enable "SystemAssigned" identity on SQL Server resources, as in the following:

resource "azurerm_sql_server" "test" {
  name                         = "mysqlserver"
  resource_group_name          = azurerm_resource_group.test.name
  location                     = "azurerm_resource_group.test.location"
  version                      = "12.0"
  administrator_login          = "mradministrator"
  administrator_login_password = "thisIsDog11"

  identity {
    type = "SystemAssigned"
  }

  tags = {
    environment = "production"
  }
}

This is a prerequisite to enabling SQL TDE with BYOK using Azure Key Vault (requested in #87)

@ghost ghost added the size/M label Oct 29, 2019
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @bgs113

Thanks for this PR - taking a look through this is looking good - if we can fix up the minor comments (and the tests pass) then this otherwise LGTM 👍

Thanks!

azurerm/resource_arm_sql_server.go Outdated Show resolved Hide resolved
azurerm/resource_arm_sql_server.go Outdated Show resolved Hide resolved
azurerm/resource_arm_sql_server.go Outdated Show resolved Hide resolved
azurerm/resource_arm_sql_server.go Show resolved Hide resolved
azurerm/resource_arm_sql_server.go Show resolved Hide resolved
azurerm/resource_arm_sql_server.go Outdated Show resolved Hide resolved
azurerm/resource_arm_sql_server.go Show resolved Hide resolved
Addresses feedback from PR #4754: make all fields case sensitive,
ensure identity block is always set, handle empty identity config
@ghost ghost added size/L documentation and removed size/M labels Oct 30, 2019
@bgs113
Copy link
Contributor Author

bgs113 commented Oct 30, 2019

I updated the SQL Server data source to include the identity information. Let me know if you have any additional feedback or need anything else to move forward.

@ghost ghost removed the waiting-response label Oct 30, 2019
@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2019-10-30 at 20 02 12

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @bgs113

Thanks for pushing those changes - taking a look through this LGTM 👍

Thanks!

@tombuildsstuff tombuildsstuff merged commit e44c0db into hashicorp:master Oct 30, 2019
tombuildsstuff added a commit that referenced this pull request Oct 30, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 30, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants