Dependencies: upgrading Azure/azure-sdk-for-go and hashicorp/go-azure-helpers
#4775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Storage (Container) tests pass:
|
This was referenced Oct 31, 2019
|
Acceptance Test results for this look the same as master 👍 |
tombuildsstuff
changed the title
Azure/azure-sdk-for-go and hashicorp/go-azure-helpersAzure/azure-sdk-for-go and hashicorp/go-azure-helpers
|
This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.37.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the following dependencies:
github.com/Azure/azure-sdk-for-gotov35.0.0github.com/Azure/go-autoresttov0.9.2github.com/hashicorp/go-azure-helperstov0.10.0The upgrade to hashicorp/go-azure-helpers includes the fix for #2602 which introduces a custom refresh function; allowing us to shell out to the Azure CLI for a replacement refresh token.
Once this PR is merged the documentation for Azure CLI authentication also needs to be updated to clarify that running longer-running tasks should be done via a Service Principal; since the refresh token itself can have custom expiry depending on the GPO's configured on the AAD Tenant (or, for example a password expiring).
Fixes #2602