New Resource: azurerm_api_management_diagnostic

[aqche]

Partially addresses: #4760

Adds the azurerm_api_management_diagnostic resource to the extent that the 2018-01-01 version of the apimanagement service allows. As noted in my comment on the feature request, I realize this doesn't have near the amount of options as the 2019-01-01 version would, but perhaps it can provide incremental value/serve as a step to addressing the issue. That being said, this is my first attempt at contributing a new resource to the provider so please let me know if you have any feedback! :)

--- PASS: TestAccAzureRMApiManagementDiagnostic_basic (2122.14s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       2122.193s

--- PASS: TestAccAzureRMApiManagementDiagnostic_requiresImport (2911.42s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       2911.465s

[tombuildsstuff]

hey @aqche

Thanks for this PR - apologies for the delayed review here!

Taking a look through here other than a few minor comments this otherwise LGTM 👍

Thanks!

[tombuildsstuff]

@aqche we're preparing to start some fairly large-scale refactoring to the codebase - as such I'm going to push a commit to fix the issues above and rebase this, so that we can get this merged before that happens; I hope you don't mind!

[tombuildsstuff]

Tests pass:

[aqche]

@tombuildsstuff thanks for the review and taking the time to make the changes as well! 🙏

[ghost]

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!