Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only lock each virtual network once #4908

Merged

Conversation

duncward
Copy link

If multiple subnets belonging to the same virtual networks are
listed in the network rules, then the deletion attempts to lock
the same virtual network twice, which can't happen because it
already owns the lock, thereby deadlocking itself.

fixes #3156

If multiple subnets belonging to the same virtual networks are
listed in the network rules, then the deletion attempts to lock
the same virtual network twice, which can't happen because it
already owns the lock, thereby deadlocking itself.

fixes hashicorp#3156
@ghost ghost added the size/XS label Nov 18, 2019
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @duncward

@tombuildsstuff tombuildsstuff added this to the v1.38.0 milestone Nov 28, 2019
@tombuildsstuff tombuildsstuff merged commit 272a9f5 into hashicorp:master Nov 28, 2019
tombuildsstuff added a commit that referenced this pull request Nov 28, 2019
@duncward duncward deleted the ddub/fix-3156/storage-account-locks branch November 28, 2019 14:32
@ghost
Copy link

ghost commented Dec 7, 2019

This has been released in version 1.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.38.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 28, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Dec 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage Accounts not destroying (1hr+)
2 participants