Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_databricks_workspace: Support for Trial SKU #5652

Merged
merged 1 commit into from Feb 11, 2020
Merged

azurerm_databricks_workspace: Support for Trial SKU #5652

merged 1 commit into from Feb 11, 2020

Conversation

johnwildes
Copy link
Contributor

@johnwildes johnwildes commented Feb 10, 2020 •
edited by tombuildsstuff

Added SKU schema validation type of "trial" to allow for setting up a Trial version of the Azure Databricks Workspace.

Fixes #5651

@johnwildes
Support for Trial SKU
2132ce8 
Added SKU schema validation type of "trial" to allow for setting up a Trial version of the Azure Databricks Workspace.
@ghost ghost added the size/XS label Feb 10, 2020
@tombuildsstuff tombuildsstuff added this to the v1.44.0 milestone Feb 10, 2020
@tombuildsstuff
Copy link
Member

Confirmed in the Portal:

Screenshot 2020-02-10 at 06 47 33

@tombuildsstuff tombuildsstuff changed the title Support for Trial SKU r/databricks_workspace: Support for Trial SKU Feb 10, 2020
tombuildsstuff
tombuildsstuff approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @johnwildes

Thanks for this PR :)

Taking a look through this LGTM - if we can update the documentation to reflect this new value then this should otherwise be good to merge 👍

Thanks!

azurerm/internal/services/databricks/resource_arm_databricks_workspace.go Show resolved Hide resolved
@johnwildes johnwildes mentioned this pull request Feb 10, 2020
Merged
@mbfrahry mbfrahry changed the title r/databricks_workspace: Support for Trial SKU azurerm_databricks_workspace: Support for Trial SKU Feb 11, 2020
@mbfrahry mbfrahry merged commit ef10091 into hashicorp:master Feb 11, 2020
mbfrahry pushed a commit that referenced this pull request Feb 11, 2020
@johnwildes
azurerm_databricks_workspace: Doc Fix for Trial SKU #5652
ee08e5f
mbfrahry added a commit that referenced this pull request Feb 11, 2020
@mbfrahry
Update Changelog for #5652
501992f
@ghost
Copy link

ghost commented Feb 12, 2020

This has been released in version 1.44.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.44.0"
}
# ... other configuration ...

@ghost ghost removed the waiting-response label Feb 12, 2020
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 28, 2020
@johnwildes johnwildes deleted the patch-1 branch March 31, 2020 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
enhancement service/databricks size/XS
Projects
None yet
Milestone
v1.44.0
Development

Successfully merging this pull request may close these issues.

Support for Trial SKU in azurerm_databricks_workspace
3 participants
@johnwildes @tombuildsstuff @mbfrahry