Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/network_interface - switching over to the association resources / introducing azurerm_network_interface_security_group_association #5784

Merged
merged 17 commits into from Feb 18, 2020

Conversation

tombuildsstuff
Copy link
Member

@tombuildsstuff tombuildsstuff commented Feb 17, 2020

This PR makes several changes to the azurerm_network_interface resource:

  • introduces a new resource for azurerm_network_interface_security_group_association - for creating an association between a Network Interface & a Network Security Group
  • removes the inline fields within the azurerm_network_interface resource
  • rewrites the Network Interface tests to account for the updated fields

Supersedes / incorporates #5765
Fixes #3298
Fixes #2234

@tombuildsstuff
Copy link
Member Author

Tests pass:

Screenshot 2020-02-17 at 12 32 26

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit d40ea07 into master Feb 18, 2020
@tombuildsstuff tombuildsstuff deleted the f/network-interface-2.0 branch February 18, 2020 13:49
tombuildsstuff added a commit that referenced this pull request Feb 18, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.