Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type of ipv4_firewall_rule for Analysis Services Server #6179

Merged

Conversation

r0bnet
Copy link
Contributor

@r0bnet r0bnet commented Mar 19, 2020

We faced the problem that the order changes in Azure side when there are more than 2 rules but we don't care about the order. That's why i changed the type to a Set instead of a List. Should fix our problems here.

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @r0bnet

@tombuildsstuff tombuildsstuff added this to the v2.3.0 milestone Mar 19, 2020
@tombuildsstuff
Copy link
Member

Tests look good:

Screenshot 2020-03-19 at 18 09 30

@tombuildsstuff tombuildsstuff merged commit e07a3b4 into hashicorp:master Mar 19, 2020
tombuildsstuff added a commit that referenced this pull request Mar 19, 2020
@r0bnet r0bnet deleted the analysis-services-server-ip4rule-set branch March 20, 2020 10:50
@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants