Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #637 - adds tags to azurerm_local_network_gateway #638

Merged
merged 3 commits into from Dec 18, 2017
Merged

Fixes #637 - adds tags to azurerm_local_network_gateway #638

merged 3 commits into from Dec 18, 2017

Conversation

russellds
Copy link

This pull request adds tags to azurerm_local_network_gateway. This addresses issue #637.

@tombuildsstuff tombuildsstuff added this to the 1.0.1 milestone Dec 16, 2017
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @russellds

Thanks for this PR - I've taken a look through and this LGTM. I've pushed a couple of commits to document this field and add a test to ensure it's set (I hope you don't mind!).

Tests pass:

$ acctests azurerm TestAccAzureRMLocalNetworkGateway_
=== RUN   TestAccAzureRMLocalNetworkGateway_importBasic
--- PASS: TestAccAzureRMLocalNetworkGateway_importBasic (81.32s)
=== RUN   TestAccAzureRMLocalNetworkGateway_importBGPSettingsComplete
--- PASS: TestAccAzureRMLocalNetworkGateway_importBGPSettingsComplete (78.60s)
=== RUN   TestAccAzureRMLocalNetworkGateway_basic
--- PASS: TestAccAzureRMLocalNetworkGateway_basic (77.83s)
=== RUN   TestAccAzureRMLocalNetworkGateway_disappears
--- PASS: TestAccAzureRMLocalNetworkGateway_disappears (77.98s)
=== RUN   TestAccAzureRMLocalNetworkGateway_tags
--- PASS: TestAccAzureRMLocalNetworkGateway_tags (78.08s)
=== RUN   TestAccAzureRMLocalNetworkGateway_bgpSettings
--- PASS: TestAccAzureRMLocalNetworkGateway_bgpSettings (77.82s)
=== RUN   TestAccAzureRMLocalNetworkGateway_bgpSettingsDisable
--- PASS: TestAccAzureRMLocalNetworkGateway_bgpSettingsDisable (96.06s)
=== RUN   TestAccAzureRMLocalNetworkGateway_bgpSettingsEnable
--- PASS: TestAccAzureRMLocalNetworkGateway_bgpSettingsEnable (94.61s)
=== RUN   TestAccAzureRMLocalNetworkGateway_bgpSettingsComplete
--- PASS: TestAccAzureRMLocalNetworkGateway_bgpSettingsComplete (77.84s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	740.200s

Thanks!

@tombuildsstuff tombuildsstuff merged commit 8bb42df into hashicorp:master Dec 18, 2017
tombuildsstuff added a commit that referenced this pull request Dec 18, 2017
@russellds
Copy link
Author

@tombuildsstuff Thank you! I'll take a look at what you changed to update the documentation so in the future I can make sure I do that as well!

@russellds russellds deleted the local_network_gateway_tags branch December 18, 2017 20:39
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants