Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update r/azurerm_kubernetes_cluster: add support for kubelet_identity #6393

Merged
merged 4 commits into from Apr 16, 2020

Conversation

aristosvo
Copy link
Collaborator

Fixes #6371

@ghost ghost added the size/M label Apr 7, 2020
@aristosvo aristosvo marked this pull request as ready for review April 7, 2020 18:31
@ghost ghost added the documentation label Apr 7, 2020
@aristosvo aristosvo force-pushed the kubeletidentity branch 2 times, most recently from d7757a3 to 89ec1df Compare April 7, 2020 18:44
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @aristosvo

Thanks for this PR :)

I've taken a look through and left some comments inline but this is looking good - from what I can see I think we can remove the top-level identity_profile block and nest the kubelet_identity block there directly, since we're not gaining anything from nesting this; but this otherwise looking pretty good 👍

Thanks!

@aristosvo aristosvo force-pushed the kubeletidentity branch 3 times, most recently from 2d70b37 to 7befa34 Compare April 8, 2020 13:04
@aristosvo
Copy link
Collaborator Author

Acceptance test passed.

==> Checking that Custom Timeouts are used...
TF_ACC=1 go test -v ./azurerm/internal/services/containers/tests/ -run=TestAccAzureRMKubernetesCluster_managedClusterIdentity -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMKubernetesCluster_managedClusterIdentity
=== PAUSE TestAccAzureRMKubernetesCluster_managedClusterIdentity
=== CONT  TestAccAzureRMKubernetesCluster_managedClusterIdentity
--- PASS: TestAccAzureRMKubernetesCluster_managedClusterIdentity (1189.16s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/containers/tests    1189.192s

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @aristosvo

Thanks for pushing those changes - taking a look through this now LGTM 👍

Thanks!

@tombuildsstuff tombuildsstuff added this to the v2.6.0 milestone Apr 16, 2020
@tombuildsstuff
Copy link
Member

Tests look good 👍

@tombuildsstuff tombuildsstuff merged commit 75481a0 into hashicorp:master Apr 16, 2020
tombuildsstuff added a commit that referenced this pull request Apr 16, 2020
@aristosvo aristosvo deleted the kubeletidentity branch April 16, 2020 15:54
@ghost
Copy link

ghost commented Apr 16, 2020

This has been released in version 2.6.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.6.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for exposing the kubelet identity for AKS cluster with MSI
2 participants