Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/mariadb_server: ensuring the ID is always set #6496

Merged
merged 4 commits into from Apr 16, 2020
Merged

Conversation

tombuildsstuff
Copy link
Member

@tombuildsstuff tombuildsstuff commented Apr 16, 2020

Fixes #6483
Fixes #6356

Also fixes the Data Source for azurerm_eventhub_namespace_authorization_rule and azurerm_network_ddos_protection_plan

@ghost ghost added size/S and removed size/XS labels Apr 16, 2020
@ghost ghost added size/M and removed size/S labels Apr 16, 2020
@tombuildsstuff tombuildsstuff requested a review from a team April 16, 2020 11:13
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment

…ace_authorization_rule.go

Co-Authored-By: Matthew Frahry <mbfrahry@gmail.com>
@tombuildsstuff tombuildsstuff merged commit 8d1cc22 into master Apr 16, 2020
@tombuildsstuff tombuildsstuff deleted the b/mariadb-ds branch April 16, 2020 15:24
tombuildsstuff added a commit that referenced this pull request Apr 16, 2020
@ghost
Copy link

ghost commented Apr 16, 2020

This has been released in version 2.6.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.6.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants