Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kusto_cluster - Support for optimized_auto_scale #7371

Merged

Conversation

jrauschenbusch
Copy link
Contributor

@jrauschenbusch jrauschenbusch commented Jun 17, 2020

Enables the usage of the optimized auto scale feature of a Kusto Cluster.

@ghost ghost added the size/M label Jun 17, 2020
@jrauschenbusch jrauschenbusch force-pushed the r-kusto-cluster-optimized-auto-scale branch from 38b19a7 to a39f845 Compare June 23, 2020 16:55
@ghost ghost added documentation size/L and removed size/M labels Jun 23, 2020
@jrauschenbusch jrauschenbusch force-pushed the r-kusto-cluster-optimized-auto-scale branch 3 times, most recently from 3b4a4f5 to 9782053 Compare June 24, 2020 13:48
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @jrauschenbusch

Thanks for this PR.

Taking a look through this mostly LGTM - there's a few changes needed here but if we can fix those up (and the tests pass) then this should otherwise be good to merge 👍

Thanks!

azurerm/internal/services/kusto/kusto_cluster_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/kusto/kusto_cluster_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/kusto/kusto_cluster_resource.go Outdated Show resolved Hide resolved
website/docs/r/kusto_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/kusto_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/kusto_cluster.html.markdown Outdated Show resolved Hide resolved
@ghost ghost added size/XXL and removed size/L labels Jun 29, 2020
@jrauschenbusch jrauschenbusch force-pushed the r-kusto-cluster-optimized-auto-scale branch 4 times, most recently from b41b329 to d30451b Compare June 29, 2020 13:56
@ghost ghost added size/L and removed size/XXL labels Jun 29, 2020
@jrauschenbusch jrauschenbusch force-pushed the r-kusto-cluster-optimized-auto-scale branch 2 times, most recently from 19e4861 to 184357f Compare June 30, 2020 04:55
@jrauschenbusch jrauschenbusch force-pushed the r-kusto-cluster-optimized-auto-scale branch from e54d8f3 to ffb220f Compare July 2, 2020 19:10
@jrauschenbusch
Copy link
Contributor Author

@tombuildsstuff Finally all acc tests are running:

@ghost ghost removed the waiting-response label Jul 2, 2020
@jrauschenbusch
Copy link
Contributor Author

@tombuildsstuff Finally acceptance tests are running. Please review.

make acctests SERVICE='kusto' TESTARGS='-run=TestAccAzureRMKustoCluster_optimizedAutoScale' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/kusto/tests/ -run=TestAccAzureRMKustoCluster_optimizedAutoScale -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMKustoCluster_optimizedAutoScale
=== PAUSE TestAccAzureRMKustoCluster_optimizedAutoScale
=== CONT  TestAccAzureRMKustoCluster_optimizedAutoScale
--- PASS: TestAccAzureRMKustoCluster_optimizedAutoScale (1997.43s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/kusto/tests 1999.638s

@jrauschenbusch jrauschenbusch force-pushed the r-kusto-cluster-optimized-auto-scale branch from 886e210 to f17bb31 Compare July 3, 2020 10:01
@mbfrahry mbfrahry changed the title Support for Kusto Optimized Auto Scale azurerm_kusto_cluster - Support for optimized_auto_scale Jul 7, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just made some minor changes with nil checks and a test fix

@mbfrahry mbfrahry merged commit 43b02a9 into hashicorp:master Jul 7, 2020
@jrauschenbusch jrauschenbusch deleted the r-kusto-cluster-optimized-auto-scale branch July 9, 2020 05:14
@mbfrahry mbfrahry added this to the v2.18.0 milestone Jul 9, 2020
@ghost
Copy link

ghost commented Jul 10, 2020

This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.18.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants