Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traffic Manager Profile: Adding support for setting protocol to tcp` #742

Merged
merged 1 commit into from Jan 23, 2018
Merged

Traffic Manager Profile: Adding support for setting protocol to tcp` #742

merged 1 commit into from Jan 23, 2018

Conversation

tombuildsstuff
Copy link
Member

Fixes #717

New test:

$ acctests azurerm TestAccAzureRMTrafficManagerProfile_weightedTCP
=== RUN   TestAccAzureRMTrafficManagerProfile_weightedTCP
--- PASS: TestAccAzureRMTrafficManagerProfile_weightedTCP (73.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	73.527s

@tombuildsstuff tombuildsstuff added this to the 1.0.2 milestone Jan 23, 2018
@tombuildsstuff tombuildsstuff mentioned this pull request Jan 23, 2018
Closed
@tombuildsstuff
Adding support for setting protocol to tcp`. Fixes #717
c4fa4a9 
```
$ acctests azurerm TestAccAzureRMTrafficManagerProfile_weightedTCP
=== RUN   TestAccAzureRMTrafficManagerProfile_weightedTCP
--- PASS: TestAccAzureRMTrafficManagerProfile_weightedTCP (73.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	73.527s
```
@tombuildsstuff
Copy link
Member Author

Tests pass:

screen shot 2018-01-23 at 12 58 03

@tombuildsstuff tombuildsstuff merged commit b6a935d into master Jan 23, 2018
@tombuildsstuff tombuildsstuff deleted the traffic-manager-tcp branch January 23, 2018 15:47
tombuildsstuff added a commit that referenced this pull request Jan 23, 2018
@tombuildsstuff
Updating to include #742
061ccdd
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paultyng paultyng paultyng approved these changes

@mbfrahry mbfrahry Awaiting requested review from mbfrahry

Assignees
No one assigned
Labels
enhancement service/traffic-manager
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Traffic Manager - Support TCP for monitor config protocol
2 participants
@tombuildsstuff @paultyng