Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management_identity_provider_aad client_secret plan refresh is not empty #7529

Merged
merged 1 commit into from Jul 7, 2020

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Jun 30, 2020

Fix: #7298

test:
=== RUN TestAccAzureRMApiManagementIdentityProviderAAD_basic
=== PAUSE TestAccAzureRMApiManagementIdentityProviderAAD_basic
=== CONT TestAccAzureRMApiManagementIdentityProviderAAD_basic
--- PASS: TestAccAzureRMApiManagementIdentityProviderAAD_basic (2416.87s)
=== RUN TestAccAzureRMApiManagementIdentityProviderAAD_update
=== PAUSE TestAccAzureRMApiManagementIdentityProviderAAD_update
=== CONT TestAccAzureRMApiManagementIdentityProviderAAD_update
--- PASS: TestAccAzureRMApiManagementIdentityProviderAAD_update (2392.69s)
=== RUN TestAccAzureRMApiManagementIdentityProviderAAD_requiresImport
=== PAUSE TestAccAzureRMApiManagementIdentityProviderAAD_requiresImport
=== CONT TestAccAzureRMApiManagementIdentityProviderAAD_requiresImport
--- PASS: TestAccAzureRMApiManagementIdentityProviderAAD_requiresImport (2855.40s)

@ghost ghost added the size/XS label Jun 30, 2020
Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yupwei68, thanks for this fix. LGTM 👍

@manicminer manicminer added this to the v2.18.0 milestone Jul 7, 2020
@manicminer manicminer merged commit d1e4883 into hashicorp:master Jul 7, 2020
manicminer added a commit that referenced this pull request Jul 7, 2020
@ghost
Copy link

ghost commented Jul 10, 2020

This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.18.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_api_management_identity_provider_aad keeps updating client_secret
2 participants