Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_kusto_cluster_principal_assignment #7533

Merged

Conversation

jrauschenbusch
Copy link
Contributor

No description provided.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jrauschenbusch, this is looking nearly there. Just a few minor things but the bulk is there! We'll also want to get the travis checks passing. I can't run the test quite yet as it's missing some arguments but testing locally looks great

@jrauschenbusch jrauschenbusch force-pushed the r-kusto-cluster-principal-assignment branch from ad021b0 to 8474e01 Compare July 1, 2020 07:21
@jrauschenbusch
Copy link
Contributor Author

@mbfrahry Everything fixed. Ready for a 2nd review.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title New Resource: azurerm_kusto_cluster_principal_assignment New Resource: azurerm_kusto_cluster_principal_assignment Jul 1, 2020
@mbfrahry mbfrahry added this to the v2.17.0 milestone Jul 1, 2020
@mbfrahry mbfrahry merged commit da888fb into hashicorp:master Jul 1, 2020
mbfrahry added a commit that referenced this pull request Jul 1, 2020
@jrauschenbusch jrauschenbusch deleted the r-kusto-cluster-principal-assignment branch July 1, 2020 16:24
@ghost
Copy link

ghost commented Jul 3, 2020

This has been released in version 2.17.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.17.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants