Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate WAF policy to Application Gateway listener (fixes 6485) #7580

Merged
merged 4 commits into from Jul 6, 2020
Merged

Associate WAF policy to Application Gateway listener (fixes 6485) #7580

merged 4 commits into from Jul 6, 2020

Conversation

rikribbers
Copy link
Contributor

No description provided.

@rikribbers
Copy link
Contributor Author

The build is failing on "make depscheck" ; error: gimme: given '1.13.x' but no release for '1.13' found

I don't know why, but does "works on my machine" count as this does not reproduce on my local machine with go 1.13.8

Looking at other build they seem to run on go 1.13 in travis. Could this be a travis hickup or am I missing something.. any feedback is highly appreciated.

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @rikribbers

Thanks for this PR :)

Taking a look through this is looking good - if we can fix up the comments then this otherwise LGTM 👍

Thanks!

@tombuildsstuff
Copy link
Member

@rikribbers taking a look through that appears to be an error within Travis, I've re-triggered this :)

@manicminer
Copy link
Member

Fixes #6485

@manicminer manicminer linked an issue Jul 6, 2020 that may be closed by this pull request
@manicminer
Copy link
Member

@rikribbers Thanks for the updates, this LGTM!

Test results:
Screenshot 2020-07-06 15 20 53

@manicminer manicminer added this to the v2.18.0 milestone Jul 6, 2020
@manicminer manicminer merged commit 673211f into hashicorp:master Jul 6, 2020
@rikribbers rikribbers deleted the appgw-ascociate-listener branch July 6, 2020 20:06
manicminer added a commit that referenced this pull request Jul 6, 2020
@ghost
Copy link

ghost commented Jul 10, 2020

This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.18.0"
}
# ... other configuration ...

@HumanJoubert
Copy link

Hi, ran into an issue with the associating the listeners. I was able to only associate one WAF policy to an application gateway. Currently i have multiply WAF polices which needs to be associated to different listeners within the same application gateway. I tried this

image

Got this error

Error: Attribute redefined

on Main.tf line 79, in resource "azurerm_application_gateway" "tenant":
79: firewall_policy_id = azurerm_web_application_firewall_policy.externalwafpolicyrdweb.id

The argument "firewall_policy_id" was already set at Main.tf:78,3-21. Each
argument may be set only once.

Any way to get this fixed ?

@ghost ghost removed the waiting-response label Jul 14, 2020
@rikribbers
Copy link
Contributor Author

Hi @HumanJoubert,

An application gateway can have 1 policy on the application gateway level. When assigning waf policies to specific listeners use the (optional) firewall_policy_id in the http_listener block of the application gateway resource.

See https://www.terraform.io/docs/providers/azurerm/r/application_gateway.html and look for the http_listener block.

@ghost
Copy link

ghost commented Aug 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure application Gateway Firewall Policy Associate Listener
4 participants