Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move HDInsight tests to 4.0 and mark 3.6 only resources deprecated #7706

Merged
merged 14 commits into from Jul 14, 2020

Conversation

kosinsky
Copy link
Contributor

@kosinsky kosinsky commented Jul 12, 2020

Implements 2.x parts for #7670

  • Updated acceptance tests for HDInsight compatible resources to 4.0
  • Marked storm, rserver and ml_services as deprecated
  • Fixed requiresImport tests (were broken since 0.12 migration)

Note ml_services an rserver tests are very flaky and fail with HDI Version'3.6' is not supported for clusterType 'MLServices' and componentVersion 'default'. most of the time
Tests for other 6 resource types are green.

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @kosinsky

Thanks for this PR :)

Taking a look through this looks good - if we can update the terminology used in the deprecation messages then this otherwise LGTM 👍

Thanks!

kosinsky and others added 7 commits July 13, 2020 07:49
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@tombuildsstuff tombuildsstuff added this to the v2.19.0 milestone Jul 14, 2020
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @kosinsky

@tombuildsstuff
Copy link
Member

Tests look good 👍 - the failing tests have been reported to the service team in this upstream issue

Screenshot 2020-07-14 at 10 07 06

@ghost
Copy link

ghost commented Jul 16, 2020

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants