Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management_subscription - Support allow_tracing property #7969

Merged
merged 6 commits into from Aug 28, 2020

Conversation

BlakeDickie
Copy link
Contributor

Resolves #7968

  • Added allow_tracing as a property on the azurerm_api_management_subscription resource.
    • Defaults to true to match the current state of the flag when subscriptions are created before this change.

@ghost ghost added the size/XS label Jul 30, 2020
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @BlakeDickie

Thanks for this PR - apologies for the delayed review here!

Taking a look through this is looking good - if we can add an acceptance test for this then this otherwise LGTM 👍

Thanks!

Type: schema.TypeBool,
Optional: true,
Default: true,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add an acceptance covering setting, and enabling/disabling this field - we should be able to add this to the 'update' test to confirm this works

@ghost ghost added size/S and removed size/XS labels Aug 24, 2020
@BlakeDickie
Copy link
Contributor Author

@tombuildsstuff No worries. I've added some acceptance tests for ensuring the new property defaults correctly and can be set to both true/false explicitly. It's my first time in this code base, so let me know if there's any tweaks that are needed.

@ghost ghost removed the waiting-response label Aug 24, 2020
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @BlakeDickie

Thanks for pushing those changes - I've taken a look through and if we can fix the one comment/issue then this otherwise LGTM 👍

Thanks!

@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2020-08-28 at 18 14 44

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @BlakeDickie 👍

@mbfrahry mbfrahry changed the title Add allow_tracing property to api_management_subscription. azurerm_api_management_subscription - Support allow_tracing property Aug 28, 2020
@mbfrahry mbfrahry merged commit d813adc into hashicorp:master Aug 28, 2020
mbfrahry added a commit that referenced this pull request Aug 28, 2020
@ghost
Copy link

ghost commented Sep 4, 2020

This has been released in version 2.26.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.26.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Allow Tracing on API Management Subscription
3 participants