Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for VMSS in-line extensions behind feature flag #8222

Merged
merged 17 commits into from Sep 1, 2020

Conversation

jackofallops
Copy link
Member

@jackofallops jackofallops commented Aug 24, 2020

This PR adds beta support for adding VM Extensions to azurerm_linux_virtual_machine_scale_set and azurerm_windows_virtual_machine_scale_set

Set the env var ARM_PROVIDER_VMSS_EXTENSIONS_BETA to anything but an empty string to enable

resolves #5976

Adds example of Service Fabric with VMSS + inline extension.

TODO's

  • docs

@ghost ghost added the size/XXL label Aug 24, 2020
@jackofallops jackofallops added enhancement service/vmss Virtual Machine Scale Sets labels Aug 24, 2020
@jackofallops jackofallops marked this pull request as ready for review August 24, 2020 14:19
@jackofallops jackofallops requested a review from a team August 24, 2020 14:20
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jackofallops

Thanks for this PR - I've taken a look through and left some comments inline - but this is off to a good start. If we can fix those up then we should be able to take another look and get this merged 👍🏻

Thanks!

azurerm/internal/provider/features.go Outdated Show resolved Hide resolved
azurerm/internal/provider/features.go Outdated Show resolved Hide resolved
extensionProfile := expandVirtualMachineScaleSetExtensions(d.Get("extension").([]interface{}))
updateProps.VirtualMachineProfile.ExtensionProfile = extensionProfile
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not an issue, for info) since this is using d.HasChange this should support mixing both the inline and external resource here as required

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few comments inline but this otherwise otherwise LGTM 👍

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments inline but this otherwise LGTM 👍

@jackofallops
Copy link
Member Author

Tests passing:
image

(failures transient / unrelated)

@jackofallops jackofallops added this to the v2.26.0 milestone Sep 1, 2020
@jackofallops jackofallops merged commit a2afa22 into master Sep 1, 2020
@jackofallops jackofallops deleted the f/vmss-extensions-beta branch September 1, 2020 14:10
jackofallops added a commit that referenced this pull request Sep 1, 2020
@ghost
Copy link

ghost commented Sep 4, 2020

This has been released in version 2.26.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.26.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement service/vmss Virtual Machine Scale Sets size/XXL
Projects
None yet
2 participants