Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/key_vault_(key|secret): updating the latest version when updating metadata #8304

Merged
merged 2 commits into from Sep 1, 2020

Conversation

tombuildsstuff
Copy link
Member

This PR updates the Key Vault Key & Key Vault Secret resources to update the latest version of the Key/Secret, rather than for an older version

Since this resource doesn't have a concept of managing multiple versions - and we currently update the latest version for other fields, this behaviourally makes sense; but arguably there's a case for a singular version of these resources (e.g. "this version of this key vault secret") - but I'm not sure how useful that would be in a TF context.

$ TF_ACC=1 go test -v ./azurerm/internal/services/keyvault/tests/ -run=TestAccAzureRMKeyVaultKey_updatedExternally
=== RUN   TestAccAzureRMKeyVaultKey_updatedExternally
=== PAUSE TestAccAzureRMKeyVaultKey_updatedExternally
=== CONT  TestAccAzureRMKeyVaultKey_updatedExternally
--- PASS: TestAccAzureRMKeyVaultKey_updatedExternally (284.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/keyvault/tests	284.541s

Fixes #6222
Supersedes #7841

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Member Author

Tests pass:

Screenshot 2020-09-01 at 09 11 26

@tombuildsstuff tombuildsstuff merged commit 5e0f71a into master Sep 1, 2020
@tombuildsstuff tombuildsstuff deleted the f/key-vault-external-updates branch September 1, 2020 07:15
tombuildsstuff added a commit that referenced this pull request Sep 1, 2020
@ghost
Copy link

ghost commented Sep 4, 2020

This has been released in version 2.26.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.26.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The provider does not update Key Vault Secret tags when there are only tag changes/content type
2 participants