Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support managed identity for "azurerm_spring_cloud_app" #8336

Merged
merged 4 commits into from Sep 4, 2020
Merged

support managed identity for "azurerm_spring_cloud_app" #8336

merged 4 commits into from Sep 4, 2020

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Sep 3, 2020

image

tombuildsstuff
tombuildsstuff requested changes Sep 3, 2020
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @njuCZ

Thanks for this PR.

I've taken a look through and left some comments inline but if we can fix those up and the tests pass then this otherwise LGTM 👍

Thanks!

azurerm/internal/services/appplatform/spring_cloud_app_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/appplatform/spring_cloud_app_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/appplatform/spring_cloud_app_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/appplatform/spring_cloud_app_resource.go Outdated Show resolved Hide resolved
website/docs/r/spring_cloud_app.html.markdown Outdated Show resolved Hide resolved
website/docs/r/spring_cloud_app.html.markdown Outdated Show resolved Hide resolved
@njuCZ
Copy link
Contributor Author

njuCZ commented Sep 3, 2020

@tombuildsstuff I have modifed this PR according to the suggestions. Could you please have a look again?

@ghost ghost removed the waiting-response label Sep 3, 2020
tombuildsstuff
tombuildsstuff approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.27.0 milestone Sep 4, 2020
@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2020-09-04 at 14 58 30

@tombuildsstuff tombuildsstuff merged commit 69158e4 into hashicorp:master Sep 4, 2020
tombuildsstuff added a commit that referenced this pull request Sep 4, 2020
@tombuildsstuff
updating to include #8336
d95465e
@ghost
Copy link

ghost commented Sep 10, 2020

This has been released in version 2.27.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.27.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Oct 4, 2020
@njuCZ njuCZ deleted the spring_cloud_app_identity branch December 16, 2020 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees

@ArcturusZhang ArcturusZhang

Labels
documentation enhancement service/spring size/L
Projects
None yet
Milestone
v2.27.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@njuCZ @tombuildsstuff @ArcturusZhang