Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_application_insights_webtests: .Kind turns to null after editing in Portal #8372

Merged
merged 2 commits into from Sep 9, 2020

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Sep 7, 2020

After doing some trivial operation on a terraform managed application insights webtest on Portal, the kind will turn into null. This seems because the request in Portal doesn't set the .kind property but the .properties.Kind. To mitigate the impact for those poor souls who want to mix the two, we side pass this problem by keeping the same way as Portal does, in read.

This fixes #8356.

Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magodo thanks for the fix. My only concern is that we should still be reading from the top-level field if it's present?

@manicminer manicminer added this to the v2.27.0 milestone Sep 9, 2020
Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo. LGTM 👍

@manicminer manicminer merged commit 67da70a into hashicorp:master Sep 9, 2020
manicminer added a commit that referenced this pull request Sep 9, 2020
@ghost
Copy link

ghost commented Sep 10, 2020

This has been released in version 2.27.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.27.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azurerm_application_insights_web_test always forces replacement after resource is changed in Portal
2 participants