Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for connecting Network Security Rules to Application Security Groups #925

Merged
merged 1 commit into from Mar 2, 2018
Merged

Adding support for connecting Network Security Rules to Application Security Groups #925

merged 1 commit into from Mar 2, 2018

Conversation

tombuildsstuff
Copy link
Member

Fixes #912

Tests pass:

$ acctests azurerm TestAccAzureRMNetworkSecurityGroup_
=== RUN   TestAccAzureRMNetworkSecurityGroup_importBasic
--- PASS: TestAccAzureRMNetworkSecurityGroup_importBasic (73.74s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_importSingleRule
--- PASS: TestAccAzureRMNetworkSecurityGroup_importSingleRule (41.86s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_importMultipleRules
--- PASS: TestAccAzureRMNetworkSecurityGroup_importMultipleRules (57.78s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_basic
--- PASS: TestAccAzureRMNetworkSecurityGroup_basic (60.71s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_singleRule
--- PASS: TestAccAzureRMNetworkSecurityGroup_singleRule (52.22s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_update
--- PASS: TestAccAzureRMNetworkSecurityGroup_update (65.59s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_disappears
--- PASS: TestAccAzureRMNetworkSecurityGroup_disappears (57.15s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_withTags
--- PASS: TestAccAzureRMNetworkSecurityGroup_withTags (48.17s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_addingExtraRules
--- PASS: TestAccAzureRMNetworkSecurityGroup_addingExtraRules (57.86s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_augmented
--- PASS: TestAccAzureRMNetworkSecurityGroup_augmented (56.66s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_applicationSecurityGroup
--- PASS: TestAccAzureRMNetworkSecurityGroup_applicationSecurityGroup (48.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	619.783s

$ acctests azurerm TestAccAzureRMNetworkSecurityRule_
=== RUN   TestAccAzureRMNetworkSecurityRule_importBasic
--- PASS: TestAccAzureRMNetworkSecurityRule_importBasic (277.23s)
=== RUN   TestAccAzureRMNetworkSecurityRule_basic
--- PASS: TestAccAzureRMNetworkSecurityRule_basic (63.75s)
=== RUN   TestAccAzureRMNetworkSecurityRule_disappears
--- PASS: TestAccAzureRMNetworkSecurityRule_disappears (59.09s)
=== RUN   TestAccAzureRMNetworkSecurityRule_addingRules
--- PASS: TestAccAzureRMNetworkSecurityRule_addingRules (72.74s)
=== RUN   TestAccAzureRMNetworkSecurityRule_augmented
--- PASS: TestAccAzureRMNetworkSecurityRule_augmented (43.52s)
=== RUN   TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups
--- PASS: TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups (61.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	578.113s

@tombuildsstuff
Adding support for connecting Network Security Rules to Application S…
4c02103 
…ecurity Groups

Tests pass:

```
$ acctests azurerm TestAccAzureRMNetworkSecurityGroup_
=== RUN   TestAccAzureRMNetworkSecurityGroup_importBasic
--- PASS: TestAccAzureRMNetworkSecurityGroup_importBasic (73.74s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_importSingleRule
--- PASS: TestAccAzureRMNetworkSecurityGroup_importSingleRule (41.86s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_importMultipleRules
--- PASS: TestAccAzureRMNetworkSecurityGroup_importMultipleRules (57.78s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_basic
--- PASS: TestAccAzureRMNetworkSecurityGroup_basic (60.71s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_singleRule
--- PASS: TestAccAzureRMNetworkSecurityGroup_singleRule (52.22s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_update
--- PASS: TestAccAzureRMNetworkSecurityGroup_update (65.59s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_disappears
--- PASS: TestAccAzureRMNetworkSecurityGroup_disappears (57.15s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_withTags
--- PASS: TestAccAzureRMNetworkSecurityGroup_withTags (48.17s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_addingExtraRules
--- PASS: TestAccAzureRMNetworkSecurityGroup_addingExtraRules (57.86s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_augmented
--- PASS: TestAccAzureRMNetworkSecurityGroup_augmented (56.66s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_applicationSecurityGroup
--- PASS: TestAccAzureRMNetworkSecurityGroup_applicationSecurityGroup (48.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	619.783s
```

```
$ acctests azurerm TestAccAzureRMNetworkSecurityRule_
=== RUN   TestAccAzureRMNetworkSecurityRule_importBasic
--- PASS: TestAccAzureRMNetworkSecurityRule_importBasic (277.23s)
=== RUN   TestAccAzureRMNetworkSecurityRule_basic
--- PASS: TestAccAzureRMNetworkSecurityRule_basic (63.75s)
=== RUN   TestAccAzureRMNetworkSecurityRule_disappears
--- PASS: TestAccAzureRMNetworkSecurityRule_disappears (59.09s)
=== RUN   TestAccAzureRMNetworkSecurityRule_addingRules
--- PASS: TestAccAzureRMNetworkSecurityRule_addingRules (72.74s)
=== RUN   TestAccAzureRMNetworkSecurityRule_augmented
--- PASS: TestAccAzureRMNetworkSecurityRule_augmented (43.52s)
=== RUN   TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups
--- PASS: TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups (61.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	578.113s
```
@tombuildsstuff tombuildsstuff added this to the 1.3.0 milestone Mar 2, 2018
@tombuildsstuff tombuildsstuff requested a review from a team March 2, 2018 19:41
mbfrahry
mbfrahry approved these changes Mar 2, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit 0c43b73 into master Mar 2, 2018
@tombuildsstuff tombuildsstuff deleted the application-security-group-rules branch March 2, 2018 21:43
tombuildsstuff added a commit that referenced this pull request Mar 2, 2018
@tombuildsstuff
Updating to include #925
22abedd
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
enhancement service/application-security-groups service/network-security
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Feature Request: support for attaching NSG Rules to Application Security Groups
2 participants
@tombuildsstuff @mbfrahry