Fix consul_node not detecting changes

[remilapeyre]

consul_node were not updating their address and meta attributes during plans. This let another bug go unnoticed where consul_service could change consul_node attributes when external would be set to true (see #101).

Multiple services could have conflicting configuration:

resource "consul_node" "compute" {
	name    = "compute-example"
	address = "www.hashicorptest.com"
}

resource "consul_service" "example1" {
	name = "example"
	node = "${consul_node.compute.name}"
	port = 80

	external = true
}


resource "consul_service" "example2" {
	name = "example"
	node = "${consul_node.compute.name}"
	port = 80

	external = true
}

// What should be the node's meta.external-probe and meta.external-node?

This patch fix resourceConsulNodeRead() and deprecate external from consul_service.
Another option would have been move external to the consul_node resource but it would then have conflicted with the meta attribute. We could use a custom DiffSuppressFunc to avoid this but I'm not sure it is worth the maintenance cost.

[Shaiou]

Hi, any news as to when this will be merged ?

[remilapeyre]

Hi @Shaiou, thanks for the ping ! We should be able to cut a new release next week :)

[Shaiou]

Hi, any news regarding the merge ?

[pearkes]

Nice, looks good. We have an upgrade guide -- should we document this change there? I assume anyone using external = true will have to do something differently now.

[Shaiou]

👍

[Shaiou]

Sorry to bother again, is there going to be a release/tag soon ?