Add consul_config_entry datasource #318
Conversation
I'm not updating the docs in this pull request as I will switch the whole provider to use terraform-plugin-docs in hashicorp#309. I will update the documentation after merging this PR. Closes hashicorp#317
There was a problem hiding this comment.
Hey @remilapeyre
I have a question about the config entry id uniqueness in here.
| return err | ||
| } | ||
|
|
||
| d.SetId(fmt.Sprintf("%s/%s", kind, name)) |
There was a problem hiding this comment.
Wouldn't id collide with other config entries with the same kind/name in other partitions/namespaces?
There was a problem hiding this comment.
id in Terraform resources or datasources is often unique but does not need to, when objects don't have a specific ID it can happen that they have the same of another.
For example Consul has this at https://github.com/hashicorp/terraform-provider-consul/blob/master/consul/resource_consul_keys.go#L188-L191 where all consul_keys resources will have the same id no matter the keys being set and another occurence of this in the Vault provider is at https://github.com/hashicorp/terraform-provider-vault/blob/main/vault/resource_generic_endpoint.go#L111 where multiple vault_generic_endpoint resources can have the same id despite being in different namespace.
Here because config entries do not have IDs and the user won't use it it does not matter what placeholder we use.
I'm not updating the docs in this pull request as I will switch the
whole provider to use terraform-plugin-docs in
#309. I will
update the documentation after merging this PR.
Closes #317