Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node-meta #65

Merged
merged 10 commits into from
Sep 21, 2018
Merged

Add node-meta #65

merged 10 commits into from
Sep 21, 2018

Conversation

pearkes
Copy link
Contributor

@pearkes pearkes commented Sep 21, 2018

Minor additions to the PR from @lawliet89 and @Zeldhyr renaming "node_meta" to "meta" in the TF resource. This aligns well with Terraform, and it shows up in both ways on the Consul API.

Closes #55 #38 #40

@ghost ghost added the size/M label Sep 21, 2018
@pearkes
Copy link
Contributor Author

pearkes commented Sep 21, 2018

Thanks for the contributions here all -- tests passing and verified some of the update behavior we were concerned about.

@pearkes pearkes merged commit 02bccef into master Sep 21, 2018
@pearkes pearkes deleted the pr/55 branch September 21, 2018 17:00
@lawliet89 lawliet89 mentioned this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants