Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Terraform Plugin Framework #184

Merged
merged 16 commits into from
Mar 1, 2023
Merged

Migrate to Terraform Plugin Framework #184

merged 16 commits into from
Mar 1, 2023

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Feb 23, 2023

Closes:
#81
#80
#77
#173

Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things, otherwise this is looking great. 👍

internal/provider/data_source.go Outdated Show resolved Hide resolved
internal/provider/data_source.go Outdated Show resolved Hide resolved
internal/provider/data_source.go Outdated Show resolved Hide resolved
docs/data-sources/external.md Show resolved Hide resolved
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

.github/workflows/test.yml Show resolved Hide resolved
@@ -3,20 +3,30 @@ module github.com/terraform-providers/terraform-provider-external
go 1.18

require (
github.com/hashicorp/go-cty v1.4.1-0.20200414143053-d3edf31b6320
github.com/hashicorp/terraform-plugin-docs v0.13.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by reminder: we should avoid this dependency from upgrading to v0.14.0 as it'll update terraform-exec to v0.18.0 which will break any acceptance tests that use TestStep > ExpectError. We can probably just let dependabot handle the upgrade when we release terraform-plugin-docs v0.14.1

Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants