Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_sql_user setting optional type and host to blank string #10034

Closed
deekthesqueak opened this issue Sep 8, 2021 · 2 comments
Closed

google_sql_user setting optional type and host to blank string #10034

deekthesqueak opened this issue Sep 8, 2021 · 2 comments
Labels

Comments

@deekthesqueak
Copy link

deekthesqueak commented Sep 8, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform v0.15.0
on darwin_amd64

  • provider registry.terraform.io/hashicorp/external v2.1.0
  • provider registry.terraform.io/hashicorp/google v3.82.0
  • provider registry.terraform.io/hashicorp/google-beta v3.82.0
  • provider registry.terraform.io/hashicorp/kubernetes v2.4.1
  • provider registry.terraform.io/hashicorp/null v3.1.0
  • provider registry.terraform.io/hashicorp/random v3.1.0

Affected Resource(s)

google_sql_user

Terraform Configuration Files

# MySQL User
resource "google_sql_user" "main" {
  name = "main"
  instance = google_sql_database_instance.main.name
  password = random_password.main_user_pass.result
  host = "%"
}

# Postgres User
resource "google_sql_user" "warehouse" {
  name = "warehouse"
  instance = google_sql_database_instance.warehouse.name
  password = random_password.warehouse_user_pass.result
}

Debug Output

Below is the plan output that I'm having issues with

https://gist.github.com/deekthesqueak/7e9f98271b9726207413d2d801563741

Panic Output

Expected Behavior

Both the type and host fields will only be changed if their value is defined, otherwise leaving them unset

Both of these values show as OPTIONAL in the documents. https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/sql_user

Actual Behavior

When planning google_sql_users resources without a type (MySQL, Postgres) will attempt to set it to blank type = ""
When planning google_sql_users resources without a host (Postgres Only) will attempt to set the value to host = ""

Steps to Reproduce

  1. Define google_sql_user resource without type and/or host
  2. terraform apply

Important Factoids

These google_sql_users were setup before Terraform v0.15.0. The passwords used in the above resources have not changed as they were randomly generated by Terraform and do not change when plans are being applied. I do not understand why the plan output has the password changing as well.

@deekthesqueak
Copy link
Author

Closing this as upon further investigation it is cased by legacy plugin SDK.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant