Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Composer image version aliases like composer-2 #11217

Closed

Comments

@swalkowski
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Cloud Composer is adding support for Composer major version aliases within image version specification, like composer-1 and composer-2. This will enable requesting a Cloud Composer 2 without specifying the full semantic version.

We should support these aliases in Terraform.

New or Affected Resource(s)

  • google_composer_environment

Potential Terraform Configuration

resource "google_composer_environment" "test" {
  name   = "example-composer-env"
  region = "us-central1"
 
 config {
    software_config {
      image_version = "composer-2-airflow-2.2.3"
    }
  }
}
@swalkowski
Copy link
Author

I have prepared a code change for this, will send out a PR soon.

@c2thorn
Copy link
Collaborator

c2thorn commented Mar 7, 2022

Note to the TF team: It looks like this will be supported by the API, however we have some regex in the provider that would have blocked it. The regex will need to be updated at the very least.

@c2thorn c2thorn removed their assignment Mar 7, 2022
@swalkowski
Copy link
Author

I have updated the regexp in a few places in GoogleCloudPlatform/magic-modules#5787 draft, please let me know if there is anything I've missed.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.