Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle gRPC ListenSocket logs #12159

Open
megan07 opened this issue Jul 21, 2022 · 5 comments
Open

Handle gRPC ListenSocket logs #12159

megan07 opened this issue Jul 21, 2022 · 5 comments

Comments

@megan07
Copy link
Contributor

megan07 commented Jul 21, 2022

Handle the ListenSocket * logs that are coming through via logrus. I think we'll want to either

  • see if we can make it work by using the standard go log for gRPC logging
  • see if we can configure logrus in a way that will work with the SDK's logging

Affected Resource(s)

  • google_bigtable_*

b/279942332

@melinath
Copy link
Collaborator

@SarahFrench
Copy link
Member

I did a quick PR to address this that didn't solve the underlying issue, so didn't close this issue

@melinath
Copy link
Collaborator

@megan07 @SarahFrench do you remember whether this is the same thing as logging request responses from GRPC or whether that would need a separate ticket?

@SarahFrench
Copy link
Member

I think that will be a separate ticket - I think this issue was about addressing why uninformative log entries (like below) are present and removing them

2022/09/06 12:14:19 [DEBUG] [core] [Server #19] Server created 
2022/09/06 12:14:19 [DEBUG] [core] [Server #19 ListenSocket #20] ListenSocket created 

@melinath
Copy link
Collaborator

Marking as bigtable since those are the only resources using grpc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants