Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: "all" protocols option is omitted in the ip_protocol argument reference of resource google_compute_firewall_policy_rule #12484

Open
jdomeracki opened this issue Sep 7, 2022 · 2 comments

Comments

@jdomeracki
Copy link

jdomeracki commented Sep 7, 2022

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The "all" protocols option is missing in the documentation of the ip_protocol argument of the layer4_configs block which is required within the match condition.

In contrast the analogous argument reference from the documentation of google_compute_firewall lists it explicitly.

New or Affected Resource(s)

google_compute_firewall_policy_rule

Potential Terraform Configuration

Such a configuration is present it the test suite:

resource "google_compute_firewall_policy_rule" "rule2" {
  firewall_policy = google_compute_firewall_policy.default.id
  description = "Resource created for Terraform acceptance testing"
  priority = 9001
  enable_logging = false
  action = "deny"
  direction = "INGRESS"
  disabled = false
  match {
    layer4_configs {
      ip_protocol = "tcp"
      ports = [80, 8080]
    }
    layer4_configs {
      ip_protocol = "all"
    }
    src_ip_ranges = ["11.100.0.1/32"]
  }
}

References

b/321386917

@rileykarson rileykarson added this to the Goals milestone Sep 12, 2022
@melinath melinath added the tpgtools Issues related to the tpgtools generator label Oct 14, 2022
@melinath
Copy link
Collaborator

This is used by our tests but not documented as an option - seems straightforward that it should be fixed. The API docs also need to be updated to reflect this is an option.

@melinath melinath removed the forward/review In review; remove label to forward label Jan 19, 2024
@DerrickTJ
Copy link

Please update the documentation.

A Google search brought me here because I assumed it was like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants