Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataplane V2 is immutable but resource updated in place #12676

Closed
Assignees
Labels

Comments

@brettcurtis
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v1.3.1
on linux_amd64
+ provider registry.terraform.io/hashicorp/google v4.38.0
+ provider registry.terraform.io/hashicorp/kubernetes v2.13.1

Affected Resource(s)

  • google_container_cluster

Terraform Configuration Files

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.kubernetes_engine.google_container_cluster.this will be updated in-place
  ~ resource "google_container_cluster" "this" ***
      + datapath_provider           = "ADVANCED_DATAPATH"
        id                          = "projects/my-project-tf1ed0cd-sb/locations/us-east1/clusters/development-tools-us-east1"
        name                        = "development-tools-us-east1"
        # (27 unchanged attributes hidden)

        # (22 unchanged blocks hidden)
    ***

Debug Output

Expected Behavior

Cluster should be destroyed and recreated

Actual Behavior

Apply ran fine but obviously cluster was not updated.

Steps to Reproduce

Build cluster with default datapath_provider then change to "ADVANCED_DATAPATH"

References

Other folks see the same behavior: terraform-google-modules/terraform-google-kubernetes-engine#656 (comment)

@edwardmedia edwardmedia self-assigned this Sep 30, 2022
@edwardmedia
Copy link
Contributor

edwardmedia commented Oct 6, 2022

Can repro on datapath_provider = "LEGACY_DATAPATH"

It looks like ADVANCED_DATAPATH can't be used as IPAllocationPolicy.UseIPAliases has not be implemented yet

│ Error: googleapi: Error 400: Clusters with DatapathProvider=ADVANCED_DATAPATH must set IPAllocationPolicy.UseIPAliases to true., badRequest
│ 
│   with google_container_cluster.primary,
│   on main.tf line 6, in resource "google_container_cluster" "primary":
│    6: resource "google_container_cluster" "primary" {

@edwardmedia
Copy link
Contributor

b/254123801

@edwardmedia
Copy link
Contributor

edwardmedia commented Oct 25, 2022

API teams has confirmed this field currently is immutable but will be made mutable sometime in 2023.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.