Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_redis_instance rdb_snapshot_period shoud be optional #12854

Closed
jcanseco opened this issue Oct 21, 2022 · 2 comments · Fixed by GoogleCloudPlatform/magic-modules#6739
Closed
Assignees
Labels

Comments

@jcanseco
Copy link
Contributor

jcanseco commented Oct 21, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Affected Resource(s)

  • google_redis_instance

Expected Behavior

It seems google_redis_instance's persistence_config.rdb_snapshot_period field should be optional as per API docs instead of required.

Original discussion: GoogleCloudPlatform/magic-modules#6528 (comment)

Actual Behavior

Field is marked required.

@c2thorn
Copy link
Collaborator

c2thorn commented Oct 25, 2022

closed with GoogleCloudPlatform/magic-modules#6739

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants