Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource_manager_tags to google_compute_instance_template #12952

Milestone

Comments

@maroux
Copy link
Contributor

maroux commented Nov 4, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Compute Instance template supports resource tags which can be used for firewall rules and IAM policy.

New or Affected Resource(s)

  • google_compute_instance_template

Potential Terraform Configuration

resource "google_tags_tag_key" "key" {
    parent = "organizations/123456789"
    short_name = "keyname"
    description = "For keyname resources."
}

resource "google_tags_tag_value" "value" {
    parent = "tagKeys/${google_tags_tag_key.key.name}"
    short_name = "valuename"
    description = "For valuename resources."
}

resource "google_compute_instance_template" "template" {
  ...

  resource_manager_tag {
    tag_key    = "tagKeys/${google_tags_tag_key.key.id}"
    tag_value = "tagValues/${google_tags_tag_value.value.id}"
  }

  resource_manager_tag {
    ...
  }
}

References

@rileykarson rileykarson added this to the Goals milestone Nov 7, 2022
@gilad9366
Copy link

Until this is developed, is there a workaround for this?
Perhaps adding the tags after creation?
I couldn't find this option either.

@github-actions github-actions bot added forward/review In review; remove label to forward service/compute-instances labels Oct 25, 2023
@LucaPrete
Copy link
Contributor

This should be ready for merge here

@LucaPrete
Copy link
Contributor

btw this seems a duplicate of this

Copy link

github-actions bot commented Feb 2, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.