Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user_labels in google_monitoring_uptime_check_config #14724

Comments

@lcoupe
Copy link

lcoupe commented May 25, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Summary

Is it expected to not be able to declare user labels via Terraform for this resource? We can see them via the API and in the console but the Terraform docs don't seem to include this block.

Any help would be greatly appreciated.

Terraform Version

1.1.3

Provider Version

4.31.0

Affected Resource(s)

  • google_monitoring_uptime_check_config

Terraform Configuration Files

resource "google_monitoring_uptime_check_config" "http-https" {
  display_name     = var.uptime_check_name
  timeout          = var.uptime_check_timeout
  period           = var.uptime_check_period
  selected_regions = var.selected_regions

  http_check {
    path         = var.http_check_path
    port         = var.http_check_port
    use_ssl      = var.http_check_ssl
    validate_ssl = var.http_check_ssl == true ? var.http_check_validate_ssl : null
    headers      = var.http_check_headers
    mask_headers = var.http_mask_headers
    dynamic "auth_info" {
      for_each = var.auth_required == true ? [1] : []
      content {
        username = var.auth_info_username
        password = var.auth_info_password
      }
    }
  }

  monitored_resource {
    type   = var.monitored_resource_type
    labels = var.monitored_resource_labels
  }

  user_labels {
    foo      = "bar"
  }

  dynamic "content_matchers" {
    for_each = var.content_matchers == true ? [1] : []
    content {
      matcher = var.content_matchers_matcher
      content = var.content_matchers_content
    }
  }
}

Debug Output

Blocks of type "user_labels" are not expected here.

Expected Behavior

Should be able to declare a block for user_labels as this is available via the API https://cloud.google.com/monitoring/api/ref_v3/rest/v3/projects.uptimeCheckConfigs

and in the console
image

Actual Behavior

Blocks of type "user_labels" are not expected here.

b/299683578

@lcoupe lcoupe added the bug label May 25, 2023
@edwardmedia edwardmedia self-assigned this May 25, 2023
@edwardmedia
Copy link
Contributor

userLabels has not been implemented

It is available in api but not in the google_monitoring_uptime_check_config yet

@edwardmedia edwardmedia removed their assignment May 25, 2023
@edwardmedia edwardmedia changed the title GCP Uptime Check Config - User Labels not accessible Add user_labels in google_monitoring_uptime_check_config May 25, 2023
@Pranav-Ch
Copy link

Thanks, is this on the roadmap or likely to be implemented anytime soon?

@github-actions github-actions bot added forward/review In review; remove label to forward service/monitoring-uptime labels Aug 17, 2023
@melinath melinath added forward/linked and removed bug forward/review In review; remove label to forward labels Sep 7, 2023
@SarahFrench SarahFrench added this to the Goals milestone Sep 11, 2023
@jdurelli
Copy link

jdurelli commented Nov 1, 2023

I will create a PR for this and some similar issues

Copy link

github-actions bot commented Dec 2, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.