Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test(s): TestAccComputeSubnetwork_subnetworkInternalL7lbExample and more #16804

Closed
shuyama1 opened this issue Dec 14, 2023 · 5 comments
Closed

Comments

@shuyama1
Copy link
Collaborator

shuyama1 commented Dec 14, 2023

Failure rates

  • 100% since 2023-12-12

Impacted tests

  • TestAccComputeSubnetwork_subnetworkInternalL7lbExample
  • TestAccComputeForwardingRule_forwardingRuleHttpLbExample
  • TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample
  • TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample
  • TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample
  • TestAccNetworkServicesGateway_minimalSwp
  • TestAccNetworkServicesGateway_networkServicesGatewayMultipleSwpSameNetworkExample
  • TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyExample
  • TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentNetwork
  • TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentSubnetwork
  • TestAccDNSRecordSet_routingPolicy

Affected Resource(s)

  • google_compute_subnetwork

Nightly build test history

Message(s)

vcr_utils.go:152: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        Terraform will perform the following actions:
          # google_compute_subnetwork.network-for-l7lb will be updated in-place
          ~ resource "google_compute_subnetwork" "network-for-l7lb" {
                id                               = "projects/xxxxxx/regions/us-central1/subnetworks/tf-test-l7lb-test-subnetworkvndk9pmf6z"
              - ipv6_access_type                 = "INTERNAL" -> null
                name                             = "tf-test-l7lb-test-subnetworkvndk9pmf6z"
                # (13 unchanged attributes hidden)
            }
        Plan: 0 to add, 1 to change, 0 to destroy.

b/316686879

@github-actions github-actions bot added forward/review In review; remove label to forward service/compute-vpc labels Dec 14, 2023
@shuyama1
Copy link
Collaborator Author

Looks like the API has started to return value INTERNAL for ipv6_access_type field when it's not explicitly set since 12/12 and this causes a permadiff in Terraform.

@melinath
Copy link
Collaborator

melinath commented Dec 14, 2023

This has also been reported a user in #16801 - I've closed it as a duplicate of this issue. Note that trying to set the value to INTERNAL results in the API Error:

Invalid value for field 'resource.ipv6AccessType': 'INTERNAL'. The IPv6 access type of a proxy-only subnet is implicitly set to INTERNAL and is not configurable.

Ideally the API would either let this value be set to INTERNAL (and only INTERNAL if that's the only valid value) or we could try to ignore the diff on the client side with a diff suppress (or customize diff if knowledge of multiple field values is required)

@SarahFrench
Copy link
Member

Notes from triage: this could be addressed with a diff suppress func in the provider, or a change to the API. The service team can choose whichever option is most appropriate.

@SarahFrench SarahFrench added this to the Goals milestone Dec 18, 2023
@rileykarson
Copy link
Collaborator

Appears to have resolved itself on 2023-12-20 after ~a week.

Copy link

github-actions bot commented Apr 4, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants