Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few small, but critical typos on documentation for google_pubsub_subscription #17645

Open
lazarillo opened this issue Mar 21, 2024 · 1 comment

Comments

@lazarillo
Copy link

lazarillo commented Mar 21, 2024

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Terraform Version

Not relevant

Affected Resource(s)

google_pubsub_subscription

Terraform Configuration

Not relevant

Debug Output

Not relevant

Expected Behavior

I expect that the syntax for a BigQuery table on the google_pubsub_subscription is accurate. I have now learned that syntax in the document is incorrect, and it should match the syntax usually used by Google Cloud:

<project>:<dataset>.<table>

Note how the first separator is a colon and the second separator is a period.

The documentation usually, but not always uses a period for both, such as:

  bigquery_config {
    table = "${google_bigquery_table.test.project}.${google_bigquery_table.test.dataset_id}.${google_bigquery_table.test.table_id}"
  }

Actual Behavior

As described above, the actually behavior is that the documentation sometimes accidentally uses a period for both separators.

Steps to reproduce

visit
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/pubsub_subscription
and read the documentation for bigquery subscriptions.

Important Factoids

No response

References

No response

b/330757367

@lazarillo lazarillo added the bug label Mar 21, 2024
@github-actions github-actions bot added forward/review In review; remove label to forward service/pubsub labels Mar 21, 2024
@ggtisc ggtisc added documentation and removed bug labels Mar 21, 2024
@ggtisc ggtisc assigned ggtisc and rileykarson and unassigned ggtisc Mar 21, 2024
@ggtisc ggtisc removed the forward/review In review; remove label to forward label Mar 21, 2024
@rileykarson rileykarson removed their assignment Mar 21, 2024
@ggtisc
Copy link
Collaborator

ggtisc commented Mar 21, 2024

@rileykarson this is a issue to improve the documentation, as the user says there are differences in some parts of the documentation where the structure to declare a bigquery_config use this <project>.<dataset>.<table> instead of this <project>:<dataset>.<table>.

Links:
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/pubsub_subscription#bigquery_config
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/pubsub_subscription#nested_bigquery_config

@ggtisc ggtisc assigned ggtisc and rileykarson and unassigned ggtisc Mar 21, 2024
@rileykarson rileykarson removed their assignment Mar 21, 2024
@rileykarson rileykarson added this to the Goals milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants