Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate wait_for_commit.sh into magician #17661

Closed
trodge opened this issue Mar 22, 2024 · 3 comments
Closed

Migrate wait_for_commit.sh into magician #17661

trodge opened this issue Mar 22, 2024 · 3 comments
Labels
fixit-technical-debt magician Issues and features related to our bespoke CI size/s technical-debt
Milestone
Near-Term Goals

Comments

@trodge
Copy link
Collaborator

trodge commented Mar 22, 2024

What kind of contribution is this issue about?

Other (specify in details)

Details

This script is one of two bash scripts remaining in production in our CI.

References

No response
@melinath melinath added this to the Goals milestone Mar 25, 2024
@rileykarson rileykarson added the magician Issues and features related to our bespoke CI label Mar 28, 2024
@melinath
Copy link
Collaborator

melinath commented Apr 5, 2024 •
edited

Script: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/scripts/bash-plus/downstream-waiter/wait_for_commit.sh
CI reference: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/gcb-push-downstream.yml

@iyabchen iyabchen mentioned this issue Apr 20, 2024
Merged
@melinath melinath modified the milestones: Goals, Near-Term Goals Apr 30, 2024
@melinath
Copy link
Collaborator

@iyabchen is working on this

@melinath
Copy link
Collaborator

Resolved by GoogleCloudPlatform/magic-modules#10504 and GoogleCloudPlatform/magic-modules#10682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixit-technical-debt magician Issues and features related to our bespoke CI size/s technical-debt
Projects
None yet
Milestone
Near-Term Goals
Development

No branches or pull requests
3 participants
@melinath @rileykarson @trodge