Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventarc dead_letter_topic configuration #17697

Open
SilverCory opened this issue Mar 27, 2024 · 2 comments
Open

Eventarc dead_letter_topic configuration #17697

SilverCory opened this issue Mar 27, 2024 · 2 comments

Comments

@SilverCory
Copy link

SilverCory commented Mar 27, 2024

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

Allow configuring and setting the dead_letter_topic for EventArc, along with all the other configuration options for the Subscription

New or Affected Resource(s)

  • google_eventarc_trigger
  • google_pubsub_subscription

Potential Terraform Configuration

resource "google_eventarc_trigger" "events-trigger" {
  name     = "trigger"
  location = var.region
  project  = var.project

  matching_criteria {
    ...
  }

  transport {
    pubsub {
      subscription {
        message_retention_seconds = 50000
        expiry = 0
        dead_letter {
          topic = google_pubsub_topic.topic.id
          delivery_attempts = 15
        }
      }
    }
  }

  destination {
    ...
  }
}

References

No response

b/331667689
b/331667948
b/331668569

@shuyama1
Copy link
Collaborator

Thanks for filing the ticket!
It doesn't look like the API supports this feature at this point. The subscription field is output-only and users can't specify this field explicitly. We can't add this to Terraform until the API supports it.

@SilverCory
Copy link
Author

SilverCory commented Mar 28, 2024

Thanks @shuyama1.

A bit iffy but if we get the subscriber from the response we can update it. It would be a multi-step process in the provider if it was done that way.

CreateEventArcTrigger(), UpdateSubscription(eventArcTrigger.transport.subscription)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants