Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_compute_backend_service.protocol documentation outdated #17741

Open
cfstras opened this issue Apr 2, 2024 · 1 comment
Open

google_compute_backend_service.protocol documentation outdated #17741

cfstras opened this issue Apr 2, 2024 · 1 comment

Comments

@cfstras
Copy link

cfstras commented Apr 2, 2024

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Terraform Version

Terraform v1.6.4
on darwin_arm64

  • provider registry.terraform.io/hashicorp/google v5.22.0
  • provider registry.terraform.io/hashicorp/google-beta v5.22.0
  • provider registry.terraform.io/hashicorp/random v3.6.0

Affected Resource(s)

google_compute_backend_service

Terraform Configuration

resource "google_compute_backend_service" "backend" {
  project = var.api_project_id

  name                  = "${var.api_project_id}cloud-run-backend"
  load_balancing_scheme = "EXTERNAL_MANAGED"

  protocol = "GRPC"
  backend {
    group = google_compute_region_network_endpoint_group.neg.self_link
  }
}

Debug Output

No response

Expected Behavior

Backend Service gets created. Note that the docs for protocol read:

Possible values are: HTTP, HTTPS, HTTP2, TCP, SSL, GRPC, UNSPECIFIED.

Actual Behavior

Error: Error creating BackendService: googleapi: Error 400: Invalid value for field 'resource.protocol': 'GRPC'. Protocol for a global EXTERNAL_MANAGED backend service must be one of TCP, SSL, HTTP, HTTPS or HTTP2 (was GRPC)., invalid

Steps to reproduce

  1. terraform apply

Important Factoids

Since HTTP2 should be equivalent in this context to GRPC, my suggestion is to just remove GRPC from the possible values in the documentation.

References

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_backend_service#protocol

b/332610086

@cfstras cfstras added the bug label Apr 2, 2024
@github-actions github-actions bot added forward/review In review; remove label to forward service/compute-l7-load-balancer labels Apr 2, 2024
@ggtisc ggtisc self-assigned this Apr 2, 2024
@ggtisc
Copy link
Collaborator

ggtisc commented Apr 2, 2024

Confirmed issue:

According to the documentation GRPC is a valid argument, but it returns an error when this value is assigned:

Error: Error creating BackendService: googleapi: Error 400: Invalid value for field 'resource.protocol': 'GRPC'. Protocol for a global EXTERNAL_MANAGED backend service must be one of TCP, SSL, HTTP, HTTPS or HTTP2 (was GRPC)., invalid

@ggtisc ggtisc removed the forward/review In review; remove label to forward label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants