Failing test(s): TestAccDataLossPreventionDiscoveryConfig_Update

[SarahFrench]

Impacted tests

• TestAccDataLossPreventionDiscoveryConfig_Update

Affected Resource(s)

• google_data_loss_prevention_discovery_config

Failure rates

• 80% since 2024-04-18

Message(s)

    vcr_utils.go:152: Step 1/4 error: Error running apply: exit status 1
        Error: Error creating DiscoveryConfig: googleapi: Error 400: All discovery configs must be in the same location, but one already exists in [us]
          with google_data_loss_prevention_discovery_config.basic,
          on terraform_plugin_test.tf line 14, in resource "google_data_loss_prevention_discovery_config" "basic":
          14: resource "google_data_loss_prevention_discovery_config" "basic" {

Nightly build test history

• https://hashicorp.teamcity.com/test/-9129528880868396147?currentProjectId=TerraformProviders_GoogleCloud_GOOGLE_NIGHTLYTESTS&expandTestHistoryChartSection=true (GA)

[SarahFrench]

Looks like it could be an issue with sweeping up dangling resources, but would need to double-check the test's config and debug logs from the test

[patrickmoy]

This could also possibly be due to tests running in parallel, though the update tests in resource_data_loss_prevention_discovery_config_test.go are set to run serially to prevent this from happening...

[melinath]

There are a number of other DLP tests - do they also need to be forced to run in serial maybe?

[patrickmoy]

No, our service restriction of one config per region per storage type only applies to DiscoveryConfig resources, so this is new.

I believe it's the example tests running simultaneously with the update tests, I found some similar merged PRs that required serial tests, but some opt to use "skip_test" on their examples. I could take a stab at that and see if it resolves.

[patrickmoy]

Can we confirm that there is still flakiness? GoogleCloudPlatform/magic-modules#10798 should have addressed this to some degree

[melinath]

It's still definitely flakey - hard to say yet if it's better than it was previously or not.