Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test(s): TestAccFirestoreDatabase_firestoreCmekDatabaseExample (Beta) #18008

Closed
SarahFrench opened this issue May 2, 2024 · 5 comments

Comments

@SarahFrench
Copy link
Member

SarahFrench commented May 2, 2024

Impacted tests

  • TestAccFirestoreDatabase_firestoreCmekDatabaseExample
  • TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample FIXED

Affected Resource(s)

  • google_firestore_database

Failure rates

  • 100% since 2024-03-04

Message(s)

=== RUN   TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample
=== PAUSE TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample
=== CONT  TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample
    vcr_utils.go:152: Step 1/2 error: Error running apply: exit status 1
        Error: Error creating Database: googleapi: Error 400: This project is not eligible to create CMEK databases.
          with google_firestore_database.database,
          on terraform_plugin_test.tf line 6, in resource "google_firestore_database" "database":
           6: resource "google_firestore_database" "database" {
--- FAIL: TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample (19.16s)
FAIL

Nightly build test history

b/339909748

@github-actions github-actions bot added forward/review In review; remove label to forward service/firestore-controlplane labels May 2, 2024
@SarahFrench SarahFrench added test-failure-100 100% fail rate and removed service/firestore-controlplane forward/review In review; remove label to forward labels May 2, 2024
@github-actions github-actions bot added forward/review In review; remove label to forward service/firestore-controlplane labels May 2, 2024
@BBBmau BBBmau added this to the Goals milestone May 6, 2024
@BBBmau BBBmau added the size/s label May 6, 2024
@melinath melinath removed the forward/review In review; remove label to forward label May 10, 2024
@melinath
Copy link
Collaborator

melinath commented May 10, 2024

Not sure what would make us "eligible" - maybe it's an allowlist? Forwarding.

@jinyangtang
Copy link

Hi, I have granted beta nightly project ci-test-project-nightly-beta the permission to create CMEK firestore database, the next run should succeed.

@SarahFrench
Copy link
Member Author

I can see that TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample passed last night 🎉

The TestAccFirestoreDatabase_firestoreCmekDatabaseExample test was previously affected by the "This project is not eligible..." error, which is now solved, but now it is failing due to a different problem. When the test attempts to delete the database at the end of the test this happens:

------- Stdout: -------
=== RUN   TestAccFirestoreDatabase_firestoreCmekDatabaseExample
=== PAUSE TestAccFirestoreDatabase_firestoreCmekDatabaseExample
=== CONT  TestAccFirestoreDatabase_firestoreCmekDatabaseExample
    testing_new.go:85: Error running post-test destroy, there may be dangling resources: exit status 1
        Error: Error when reading or editing Database: googleapi: Error 409: There are concurrent database changes, please try again.
--- FAIL: TestAccFirestoreDatabase_firestoreCmekDatabaseExample (40.02s)
FAIL

I'll update the issue description

@SarahFrench SarahFrench changed the title Failing test(s): TestAccFirestoreDatabase_firestoreCmekDatabase* (Beta) Failing test(s): TestAccFirestoreDatabase_firestoreCmekDatabaseExample (Beta) May 22, 2024
@SarahFrench
Copy link
Member Author

It may be just a bad luck, or this newly-exposed error might be flakey. We'll see with time

@melinath
Copy link
Collaborator

@SarahFrench what would you think about closing this ticket and then we'll open a new one with the new failure if it fails consistently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants