Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pull_external field from example definitions #18051

Closed
zli82016 opened this issue May 8, 2024 · 0 comments 路 Fixed by GoogleCloudPlatform/magic-modules#10745
Closed

Remove pull_external field from example definitions #18051

zli82016 opened this issue May 8, 2024 · 0 comments 路 Fixed by GoogleCloudPlatform/magic-modules#10745
Assignees
@zli82016
Labels
fixit-technical-debt mmv1-generator Provider-wide changes to resource templates or other generator changes service/terraform technical-debt
Milestone
2024Q2 Fixit

Comments

@zli82016
Copy link
Collaborator

zli82016 commented May 8, 2024 •
edited

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

A new field external_providers is introduced to replace pull_external.
https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/provider/terraform/examples.rb#L152

Clean up pull_external field from the example definition and logic to generate tests
https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/provider/terraform/examples.rb#L149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zli82016 zli82016

Labels
fixit-technical-debt mmv1-generator Provider-wide changes to resource templates or other generator changes service/terraform technical-debt
Projects
None yet
Milestone
2024Q2 Fixit
Development

Successfully merging a pull request may close this issue.

Remove deprecated pull_external from example object zli82016/magic-modules
1 participant
@zli82016