Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource for Managed Folders in GCS #18053

Open
eh-john opened this issue May 8, 2024 · 3 comments
Open

Add resource for Managed Folders in GCS #18053

eh-john opened this issue May 8, 2024 · 3 comments

Comments

@eh-john
Copy link

eh-john commented May 8, 2024

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

There is a new managed folder feature for GCS that can't be created in terraform yet. It appears to have API support already as it describes the REST APIs needed to create one in the docs.

It looks like the version of the Go SDK that this is using supports it too.

Having this resource available allows one to set permissions at a path level in GCS.

New or Affected Resource(s)

  • google_storage_managed_folder

Potential Terraform Configuration

resource "google_storage_managed_folder" "managed_folder" {
    bucket = "bucket here"
    name   = "folder_name"
}
data "google_storage_managed_folder" "managed_folder" {
    bucket = "bucket here"
    name   = "folder_name"
}

References

https://cloud.google.com/storage/docs/creating-managing-managed-folders#rest-apis_1
https://cloud.google.com/storage/docs/managed-folders

b/340252275

@github-actions github-actions bot added forward/review In review; remove label to forward service/storage labels May 8, 2024
@eh-john eh-john changed the title Managed folders support Add resource for Managed folders in GCS May 8, 2024
@eh-john eh-john changed the title Add resource for Managed folders in GCS Add resource for Managed Folders in GCS May 8, 2024
@hassannmoussaa
Copy link

Please assign this issue to me , ill open a PR for it

@SarahFrench
Copy link
Member

Note from triage: This is the API for the new resource https://cloud.google.com/storage/docs/json_api/v1/managedFolder/insert

@juliocc
Copy link

juliocc commented May 24, 2024

Apologies for the overlap! I didn't realize this was already assigned and I started working on it due to an urgent customer request. My PR (GoogleCloudPlatform/magic-modules#10786) already incorporates IAM and addresses all the details with import. Hope we can work this out.

/cc @ludoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants