Add validation for disk names.

[natedogith1]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to a user, that user is claiming responsibility for the issue.
• Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

Disk names should be validated during the plan.

New or Affected Resource(s)

• google_compute_disk

Potential Terraform Configuration

This should fail, because underscores (_) aren't allowed in disk names.

resource "google_compute_disk" "default" {
  name  = "test_disk"
  type  = "pd-ssd"
  zone  = "us-central1-a"
  image = "debian-11-bullseye-v20220719"
  labels = {
    environment = "dev"
  }
  physical_block_size_bytes = 4096
}

References

#12378

b/341735700

[melinath]

Note: It may be possible to use ValidateGCEName for this, assuming the logic matches the API logic in all cases.