google_compute_public_advertised_prefix should return attribute shared_secret

[acharrett]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to a user, that user is claiming responsibility for the issue.
• Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

As part of the process of provisioning a GCP Public Advertised Prefix, there is a step to create a DNS PTR record with the sharedSecret attribute that is created by GCP when the Public Advertised Prefix is created.

See the reference doc at GCP https://cloud.google.com/vpc/docs/create-pap#ptr-name

It would make the process of end to end provisioning GCP BYOIP much easier if the google_compute_public_advertised_prefix module returned that shared secret value so that the DNS step can subsequently be created.

Although the attribute is named secret, I don't think it needs to be marked sensitive in terraform as the first thing you do is add it to public DNS.

The shared secret can be viewed using the CLI command gcloud compute public-advertised-prefixes describe PAP_NAME --format=json | jq '.sharedSecret'

Also while dns_verification_ip is an argument to google_compute_public_advertised_prefix already, it would be convenient for both shared_secret and dns_verification_ip to be returned together, but shared_secret is the really important one.

New or Affected Resource(s)

• google_compute_public_advertised_prefix

Potential Terraform Configuration

References

https://cloud.google.com/vpc/docs/create-pap#ptr-name

b/341735188