Change affected AtLeastOneOfs back to ExactlyOneOf

[danawillow]

See #5024

This affects:

• google_compute_firewall
• google_folder_organization_policy
• google_organization_policy
• google_project_organization_policy
• google_compute_health_check
• google_compute_region_health_check

Because of hashicorp/terraform-plugin-sdk#280, several fields that were ExactlyOneOf were changed to AtLeastOneOf. In the next major release after the blocking issue is fixed, change them back.

[mholleville]

Hello !

Do you have a date for the availability of these new features? It is quite structuring on the firewall part etc..

[danawillow]

The behavior of this should be correct as of GoogleCloudPlatform/magic-modules#2856. This specific issue is to simplify the code by having it be ExactlyOneOf instead of AtLeastOneOf+ConflictsWith. Are you seeing otherwise? I'm not totally sure from your comment what you mean by "it is quite structuring on the firewall part"

[j-don]

Not sure if this is the right place to report this, but 3.20.0 seems to have reintroduced the issue described in hashicorp/terraform-plugin-sdk#280 that links to this issue. We ran into that same error signature today when applying terraform-google-modules/network/google//modules/fabric-net-firewall modules, and rolling back to 3.19.0 fixed it.

[danawillow]

Oh gosh, we never revendored the SDK after they fixed it on their end 🤦‍♀️

I'll go ahead and do that now for our next release.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!