Handle new-style Status error responses correctly

[rileykarson]

http://aip.dev/193 states that APIs should return errors as a Status message, including a standard set of details payloads. This gist is an example, from Cloud Run.

We parse errors using googleapi.CheckResponse, which returns the googleapi.Error format. While Status and googleapi.Error share code and message, they refer to their details as details and errors respectively. This lead to a series of Cloud Run issues where we returned useless error messages like "The request has errors" while extra information was available under details.

Interestingly, the generated service clients all use googleapi.CheckResponse as well, even for Cloud Run. I filed an issue against them as googleapis/google-api-go-client#473. It's likely that our best solution is to wait that fix out, however, this issue can be used to dedupe similar issues in the meantime.

[rileykarson]

googleapis/google-api-go-client#473 has since been resolved. Judging by their average release cadence, in around a week, we can revendor those clients and close this out.

[rileykarson]

https://github.com/googleapis/google-api-go-client/releases/tag/v0.24.0 is released including the change.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!