Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support serverless NEG #6749

Closed
Sytten opened this issue Jul 7, 2020 · 7 comments · Fixed by GoogleCloudPlatform/magic-modules#3807, #6960 or hashicorp/terraform-provider-google-beta#2348

Comments

@Sytten
Copy link

Sytten commented Jul 7, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Serverless NEGs are now in open beta: https://cloud.google.com/load-balancing/docs/negs/setting-up-serverless-negs
This means they can now be implemented in the beta provider 🎉

New or Affected Resource(s)

  • google_compute_serverless_network_endpoint_group

Potential Terraform Configuration

resource "google_compute_serverless_network_endpoint_group" "neg_cloud_run" {
  name         = "my-lb-neg"
  region         = "us-central1"
  cloud_run {
    service = "myservicename"
    tag = "revension-0010" # Optional
    url_mask = ".example.com/" # Optional
  }
}

resource "google_compute_serverless_network_endpoint_group" "neg_gae" {
  name         = "my-lb-neg"
  region         = "us-central1"
  app_engine {
    service = "myservicename"
    version = "202007071054" # Optional, default to latest
    url_mask = "-dot-appname.appspot.com/" # Optional
  }
}

resource "google_compute_serverless_network_endpoint_group" "neg_gcf" {
  name         = "my-lb-neg"
  region         = "us-central1"
  cloud_function {
    service = "myservicename"
    version = "202007071054" # Optional, default to latest
    url_mask = "/" # Optional
  }
}

References

*Requires also the fix from #6155 since it also does not support a health check

API Docs
Overview
Walkthrough

@Sytten
Copy link
Author

Sytten commented Jul 7, 2020

@danawillow I suggest also bumping #6155 to the same level otherwise this improvement is basically useless since you can't use it in the load balancer.

@danawillow danawillow added this to the Near-Term Goals milestone Jul 7, 2020
@danawillow
Copy link
Contributor

That specific issue is for global NEGs, whereas this one is for regional. Can you explain further what the connection is?

@Sytten
Copy link
Author

Sytten commented Jul 7, 2020

The problem is not related to global vs regional NEG, the problem is that google_compute_backend_service requires the parameter health_checks. That means that the (future) serverless NEG and the global NEG will not be usable since both not support the health check.

@danawillow
Copy link
Contributor

Got it, thanks for the explanation! Will update that one to match this milestone / priority label.

@brucearctor
Copy link

@Sytten -- serverless NEG and global NEG -- not supporting health_checks . Is there a design/choice for the way forward here? Is it that these services need to support health check? So the services need modified? Or, that google_compute_backend_service needs to be modified for health_checks to be optional? Or ?? Verifying I understand what has been identified at issue here. I'm interested in this feature existing, so trying to figure out the extent I capable of helping.

@Sytten
Copy link
Author

Sytten commented Jul 20, 2020

The google_compute_backend_service needs to be modified to make the health check optional for sure. Otherwise I don't really more insight into the issue, I just know it is necessary for the serverless NEG to be of any practical use.

@ghost
Copy link

ghost commented Sep 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.