Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for redis 5.0 to google_redis_instance #6850

Comments

@AlistairB
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

https://www.terraform.io/docs/providers/google/r/redis_instance.html#redis_version supports a maximum version of REDIS_4_0. However, version 5.0 is now supported https://cloud.google.com/memorystore/docs/redis/supported-versions#current_versions . According to https://cloud.google.com/memorystore/docs/redis/release-notes it reached GA on June 3rd 2020.

New or Affected Resource(s)

  • google_redis_instance

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.
resource "google_redis_instance" "cache" {
  name           = "tf-test%{random_suffix}"
  tier           = "STANDARD_HA"
  memory_size_gb = 1

  location_id             = "us-central1-a"
  alternative_location_id = "us-central1-f"

  authorized_network = google_compute_network.network.id
  connect_mode       = "PRIVATE_SERVICE_ACCESS"

  redis_version     = "REDIS_5_0"
  display_name      = "Terraform Test Instance"

  depends_on = [ google_service_networking_connection.private_service_connection ]
}

References

@ghost ghost added the enhancement label Jul 24, 2020
@danawillow danawillow added this to the Sprint 18 milestone Jul 27, 2020
@danawillow
Copy link
Contributor

Hey @AlistairB, we don't actually do any client-side validation on that field so you should be able to set it to whatever value you want. Updated this issue to mark it as a docs fix only.

@ghost
Copy link

ghost commented Sep 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.