Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing timeout for deleting default network #6852

Closed
bharathkkb opened this issue Jul 24, 2020 · 6 comments · Fixed by GoogleCloudPlatform/magic-modules#3784, #6859 or hashicorp/terraform-provider-google-beta#2306
Assignees
Labels

Comments

@bharathkkb
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

0.12.29

Affected Resource(s)

  • google_project

Terraform Configuration Files

resource "google_project" "my_project" {
  name                = "My Project"
  project_id          = "your-project-id"
  org_id              = "1234567"
  auto_create_network = false
}

Error Output

https://gist.github.com/bharathkkb/535bf78a188407a0f1d9fd9943881c7f

Expected Behavior

It should have deleted the default network successfully.

Actual Behavior

It timed out due to delay in API activation.

Steps to Reproduce

Sporadic and hard to repro. I can give additional logs for example builds if needed.
I believe this is originating from here:
https://github.com/terraform-providers/terraform-provider-google/blob/09bc2e2c9145ec8c07b689a28bfccdc22d49ad6d/google/resource_google_project.go#L176
and a possible workaround would be to bump the timeout (currently 4m).

From the Cloud Logs I see that enablement took a little over 4m
request received at 14:34:42.913 PDT and enabled at 14:38:55.372 PDT

  1. terraform apply

Important Factoids

Adding org policy for skipping default networks is a workaround.

References

/cc @morgante @daniel-cit

@ghost ghost added the bug label Jul 24, 2020
@edwardmedia edwardmedia self-assigned this Jul 24, 2020
@edwardmedia
Copy link
Contributor

@bharathkkb yes, please provide additional logs for example builds

@edwardmedia
Copy link
Contributor

@rileykarson what do you think about this?

@bharathkkb
Copy link
Author

Logs have been sent privately.

@rileykarson
Copy link
Collaborator

rileykarson commented Jul 27, 2020

google_project actually implements Timeouts, although it's missing that fact in the documentation. As a workaround, you can add user-defined timeouts as well. A little less invasive than a new org policy 🙂

I'll add that documentation, and bump the default timeout for actions on project from 4 to 10 minutes. It's a substantial amount of headroom compared to the real time actions take, but projects are a particularly unfortunate resource to get into weird states due to timeouts.

@bharathkkb
Copy link
Author

Thanks @rileykarson !!!

@ghost
Copy link

ghost commented Aug 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.